[Skiboot] [PATCH] occ: hbrt: Change the OCC reset order
stewart at linux.vnet.ibm.com
Thu Nov 12 15:48:10 AEDT 2015
Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:
>> I'd *much* prefer us to have a way programatically to work this out
>> rather than just assuming - it smells like a way to get this subtley
>> incorrect on random future machines.
> Yes agree. It would be better if FSP could send the chipID to reset. Then we
> don't have to hardcode and can reset OCCs in the order FSP requests.
> What do you suggest?
Perhaps we could just have a method in hw/occ.c or hw/cpu.c or something
that returns it? At least for the time being?
>> also, isn't for_each_chip() in chip-id order anyway? next_chip() (used
>> by for_each_chip) does go in-order through the chips array which is
>> referenced by chip id, so I wonder why the sort is needed.
> I have sorted to avoid hard-coding chip-id check 'if(chip-id == 0 || chip-id ==1)'
> Okay. If for_each_chip() is already sorted, then I can remove the sorting and
> assign the master and slave chip arrays directly.
Ready to send a revised patch with this change?
More information about the Skiboot