[Skiboot] [PATCH v2 03/10] external/gard: Clean after check to avoid leaving bad .o files around

[Cyril Bur]

On Thu, 12 Nov 2015 11:46:19 +1100
Alistair Popple <alistair at popple.id.au> wrote:

> Not a huge issue but does this mean you can't manually re-run the gard tool 
> after running make check-gard to debug it? What was the issue with leaving .o 
> files around?
> 

Hmmmm, yes it will mean that, perhaps should move the cleaning to the check
part.

What I'm trying to fix is the issue that if you run `make check` with a
CROSS_COMPILE set, libflash will need to exist for both the CROSS and HOST,
because the testing for the gard tool executes it on the host but `make check`
intends to run skiboot in ppc64-qemu...

I have no doubt this could be dealt with better but looks like this works and
it isn't all that invasive, having a few extra recompiles of the gard tool
isn't the end of the world.

> On Wed, 11 Nov 2015 15:39:57 Cyril Bur wrote:
> > Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> > ---
> >  external/gard/test/Makefile.check | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/external/gard/test/Makefile.check   
> b/external/gard/test/Makefile.check
> > index 27f1aa0..ec4993a 100644
> > --- a/external/gard/test/Makefile.check
> > +++ b/external/gard/test/Makefile.check
> > @@ -2,9 +2,13 @@
> >  
> >  check: check-gard
> >  
> > -#Makefile knows to build it before checking
> > -check-gard:
> > +#Makefile knows to build it before checking, should also
> > +#make clean before checking. If not, .o files for different
> > +#architectures might be lying around and clean once done to
> > +#avoid the opposite
> > +check-gard: gard-test-clean
> >  	@make CROSS_COMPILE='' -C external/gard/ check
> > +	@make CROSS_COMPILE='' -C external/gard/ clean
> >  
> >  .PHONY: check-gard
> >  
> >   
>