[Skiboot] [PATCH v2 00/10] Bring gard tool inline with pflash

[Cyril Bur]

On Thu, 12 Nov 2015 11:58:12 +1100
Alistair Popple <alistair at popple.id.au> wrote:

> My makefile-fu is not up to date enough to provide any meaningful comment on 
> the Makefile changes although they look reasonable enough as far as I can 
> tell. Everything else looks good.
> 
> Cyril did we ever port pflash to use your flash/file/mtd backend goodness?
> 

Yeah, I used pflash as a guinea pig to demonstrate that all that magic worked.

> - Alistair
> 
> On Wed, 11 Nov 2015 15:39:54 Cyril Bur wrote:
> > Note: the first two patches in this series are fixes for memory leaks found
> > during this work.
> > 
> > Quite a bit of work went into pflash to abstract out arch and reduce code
> > duplication when accessing system flash (or binary images of the flash).
> > 
> > This series updates the gard tool to do all that.
> > 
> > 
> > Cyril Bur (10):
> >   external/common: Don't leak temporary filename
> >   external/gard: Fix memory leak
> >   external/gard: Clean after check to avoid leaving bad .o files around
> >   external/common: Don't just expect `sh` to be in $PATH
> >   external/pflash: Fixup LDFLAGS
> >   external/gard: Update gard building to use external/common files
> >   external/tests: Add ability to strip version string from result
> >   external/gard: Add version information
> >   external/gard: Make use of the common/ flash reading code
> >   external/gard: Add make dist
> > 
> >  external/common/arch_flash_powerpc.c    |   3 +-
> >  external/common/get_arch.sh             |   2 +-
> >  external/common/rules.mk                |   2 +-
> >  external/gard/Makefile                  |  65 ++++++-----
> >  external/gard/Makefile.dist             |  10 ++
> >  external/gard/gard.c                    | 184   
> +++++---------------------------
> >  external/gard/rules.mk                  |  35 ++++++
> >  external/gard/test/Makefile.check       |   8 +-
> >  external/gard/test/results/02-usage.out |   1 +
> >  external/gard/test/tests/02-usage       |   2 +
> >  external/pflash/rules.mk                |   5 +-
> >  external/test/test.sh                   |   6 ++
> >  12 files changed, 134 insertions(+), 189 deletions(-)
> >  create mode 100644 external/gard/Makefile.dist
> >  create mode 100644 external/gard/rules.mk
> > 
> >   
>