[Skiboot] [PATCH] opal-prd: display explicit message on IBM Power systems

Cédric Le Goater clg at fr.ibm.com
Wed Nov 11 07:42:48 AEDT 2015


Hello,

On 11/10/2015 08:50 PM, Benjamin Herrenschmidt wrote:
> On Tue, 2015-11-10 at 18:48 +0100, Cédric Le Goater wrote:
>>  
>> +static const char * const openpower_systems[] = {
>> +	"ibm,firestone", "tyan,habanero", "tyan,palmetto"
>> +};
> 
> Hi Cedric !
> 
> I'm not fan of this. For each new machine (Garrison, Rattlesnake, ...)
> we'll have to update the binary.

Indeed ...

> We should instead look for the properties that indicate the supprot for
> the PRD in the device-tree. Jeremy, what do you recommend ?
 
and for that purpose, we already have :  

	/sys/firmware/devicetree/base/ibm,opal/diagnostics/

I will let Jeremy comment on the v2.

Thanks,

C. 



More information about the Skiboot mailing list