[Skiboot] [PATCH 30/36] sparse: fix beint32_t degrades to int wantings in hdata/spira.c

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 10 15:18:24 AEDT 2015


hdata/spira.c:757:14: warning: restricted beint32_t degrades to integer
hdata/spira.c:773:14: warning: restricted beint32_t degrades to integer

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hdata/spira.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hdata/spira.c b/hdata/spira.c
index b35ca9cb19b9..d0b0ce8672e0 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -754,7 +754,7 @@ static void add_iplparams_ipl_params(const void *iplp, struct dt_node *node)
 	 * and the FSP expects the firmware to reset the PCI bus
 	 * numbers and respond with a Power Down (CE,4D,02) message
 	 */
-	if (p->other_attrib & IPLPARAMS_OATTR_RST_PCI_BUSNO)
+	if (be32_to_cpu(p->other_attrib) & IPLPARAMS_OATTR_RST_PCI_BUSNO)
 		dt_add_property_cells(node, "pci-busno-reset-ipl", 1);
 	dt_add_property_strings(node, "cec-ipl-side",
 				(p->ipl_side & IPLPARAMS_CEC_FW_IPL_SIDE_TEMP) ?
@@ -770,7 +770,7 @@ static void add_iplparams_ipl_params(const void *iplp, struct dt_node *node)
 	led_node = dt_find_by_path(opal_node, DT_PROPERTY_LED_NODE);
 	assert(led_node);
 
-	if (p->other_attrib & IPLPARAMS_OATRR_LIGHT_PATH)
+	if (be32_to_cpu(p->other_attrib) & IPLPARAMS_OATRR_LIGHT_PATH)
 		dt_add_property_strings(led_node, DT_PROPERTY_LED_MODE,
 					LED_MODE_LIGHT_PATH);
 	else
-- 
2.1.4



More information about the Skiboot mailing list