[Skiboot] [PATCH 34/36] sparse: correct endian conversion of sglist

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 10 15:18:28 AEDT 2015


No generated code change for skiboot, as is BE

hw/fsp/fsp-dump.c:422:31: warning: invalid assignment: +=
hw/fsp/fsp-dump.c:422:31:    left side has type signed long long
hw/fsp/fsp-dump.c:422:31:    right side has type restricted beint64_t

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hw/fsp/fsp-dump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/fsp/fsp-dump.c b/hw/fsp/fsp-dump.c
index ae5bfeee0871..b1dd090e23db 100644
--- a/hw/fsp/fsp-dump.c
+++ b/hw/fsp/fsp-dump.c
@@ -419,7 +419,7 @@ static int64_t validate_dump_sglist(struct opal_sg_list *list,
 
 		for (i = 0; i < num_entries; i++) {
 			entry = &sg->entry[i];
-			*size += entry->length;
+			*size += be64_to_cpu(entry->length);
 
 			/* All entries must be aligned */
 			if (((uint64_t)be64_to_cpu(entry->data)) & 0xfff)
-- 
2.1.4



More information about the Skiboot mailing list