[Skiboot] [PATCH 09/36] Fix two sparse warnings on __stack_chk_guard

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 10 15:18:03 AEDT 2015


core/utils.c:25:35: warning: constant 0xdeadf00dbaad300d is so big it is unsigned long
core/utils.c:25:15: warning: symbol '__stack_chk_guard' was not declared. Should it be static?

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 core/utils.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/utils.c b/core/utils.c
index 5d86ed02f100..4bb89df06f63 100644
--- a/core/utils.c
+++ b/core/utils.c
@@ -22,7 +22,8 @@
 #include <cpu.h>
 #include <stack.h>
 
-unsigned long __stack_chk_guard = 0xdeadf00dbaad300d;
+extern unsigned long __stack_chk_guard;
+unsigned long __stack_chk_guard = 0xdeadf00dbaad300dULL;
 
 void __noreturn assert_fail(const char *msg)
 {
-- 
2.1.4



More information about the Skiboot mailing list