[Skiboot] [PATCH 03/36] Fix sparse warnings in init_boot_tracebuf()

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 10 15:17:57 AEDT 2015


core/trace.c:43:42: warning: incorrect type in assignment (different base types)
core/trace.c:43:42:    expected restricted beint64_t static [toplevel] [usertype] mask
core/trace.c:43:42:    got int
core/trace.c:44:46: warning: incorrect type in assignment (different base types)
core/trace.c:44:46:    expected restricted beint32_t static [toplevel] [usertype] max_size
core/trace.c:44:46:    got unsigned long

Shouldn't affect any runtime code, just cleans up the warnings.

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 core/trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/trace.c b/core/trace.c
index 15e505a00da9..7f06764c68b9 100644
--- a/core/trace.c
+++ b/core/trace.c
@@ -40,8 +40,8 @@ static struct {
 void init_boot_tracebuf(struct cpu_thread *boot_cpu)
 {
 	init_lock(&boot_tracebuf.trace_info.lock);
-	boot_tracebuf.trace_info.tb.mask = BOOT_TBUF_SZ - 1;
-	boot_tracebuf.trace_info.tb.max_size = MAX_SIZE;
+	boot_tracebuf.trace_info.tb.mask = cpu_to_be64(BOOT_TBUF_SZ - 1);
+	boot_tracebuf.trace_info.tb.max_size = cpu_to_be32(MAX_SIZE);
 
 	boot_cpu->trace = &boot_tracebuf.trace_info;
 }
-- 
2.1.4



More information about the Skiboot mailing list