[Skiboot] [PATCH] slw: Move add_cpu_idle_state_properties() to add_opal_node()

Stewart Smith stewart at linux.vnet.ibm.com
Mon Nov 9 14:21:00 AEDT 2015

Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com> writes:

> 05f52a8dd7c7e402896e049fd24f83d56b70aff4 core: Setup the OPAL DT node
> before platform probe
> add_cpu_idle_state_properties() was made local to slw.c in the above
> commit which caused p7 systems to not populate the nap idle state in
> DT. So moving add_cpu_idle_state_properties() to add_opal_node to fix
> this bug.
> Reported-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat at linux.vnet.ibm.com>

thanks, merged to master as of b5d4978

We still miss the ibm,enabled-idle-states on P7 though. Not sure what
effect this has (haven't looked), maybe Vaidy knows?

We should likely clean up some of this code a bit, as there's certainly
differences between chips and there's likely to be more in the
future.... and considering how well things still work when you disable
any power saving, I'd like it to be hard for us to accidentally do that.

More information about the Skiboot mailing list