[Skiboot] [RESEND PATCH v2] hdata/memory: Add dimm frequency information

Stewart Smith stewart at linux.vnet.ibm.com
Fri May 22 14:37:00 AEST 2015


Neelesh Gupta <neelegup at linux.vnet.ibm.com> writes:
> Fetch the memory bus frequency present in PCIA area and
> add this information to the memory node.
>
> ms-dimm at d000 {
> 	[...]
> 	description = "32GB CDIMM";
> 	ibm,loc-code = "U78C9.001.WZS03HU-P1-C16";
> 	ibm,memory-bus-frequency = <0x0 0x5f5e1000>;
> 	serial-number = "YH10M147C1L1";
> 	fru-type = [4d 53];
> 	[...]
> };
>
> Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>
> Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>
> v1 -> v2
>
> - Document the new property 'ibm,memory-bus-frequency' under DIMM
>   VPD node.
>
>  doc/device-tree/vpd.txt |    2 ++
>  hdata/memory.c          |   54 +++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 54 insertions(+), 2 deletions(-)
>
> diff --git a/doc/device-tree/vpd.txt b/doc/device-tree/vpd.txt
> index 949ee0b..4e0c8dd 100644
> --- a/doc/device-tree/vpd.txt
> +++ b/doc/device-tree/vpd.txt
> @@ -15,6 +15,8 @@ part-number		: Part number
>  serial-number		: Serial number
>  ibm,chip-id		: Processor Id
>  size			: DIMM size (applicable for DIMM VPD only)
> +ibm,memory-bus-frequency: DIMM frequency (applicable for DIMM VPD only),
> +			  provided as part of the HDAT structure.


Do we get it from anywhere on OpenPower? Perhaps HostBoot gives it to
us?

We should avoid being FSP specific in docs and rather mention that this
property is optional and then go on to descirbe how this works on FSP
machines.



More information about the Skiboot mailing list