[Skiboot] [PATCH] core/console: fix dummy_console_poll

Alistair Popple alistair at popple.id.au
Thu May 14 13:57:59 AEST 2015

If a console driver was registered dummy_console_poll() always sends
an opal event indicating there is pending console data even if there
wasn't. This was caused by setting a bool to the address of a function
pointer instead of calling the function.

Signed-off-by: Alistair Popple <alistair at popple.id.au>
 core/console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/console.c b/core/console.c
index bc8eed8..df3ce3b 100644
--- a/core/console.c
+++ b/core/console.c
@@ -349,7 +349,7 @@ static void dummy_console_poll(void *data __unused)
 	if (con_driver && con_driver->poll_read)
-		has_data = con_driver->poll_read;
+		has_data = con_driver->poll_read();
 	if (memcons.in_prod != memcons.in_cons)
 		has_data = true;
 	if (has_data)

More information about the Skiboot mailing list