[Skiboot] [PATCH] core: Add node-style memory reservation to device tree

Stewart Smith stewart at linux.vnet.ibm.com
Thu May 14 13:39:13 AEST 2015


Jeremy Kerr <jk at ozlabs.org> writes:

> Hi Stewart,
>
>> 387871856: (387871851): [    0.000000] Reserved memory: failed to reserve memory
>>  for node 'ibm,firmware-stacks at 31a00000': base 0x0000000031a00000, size 0 MiB
>> 388038641: (388038636): [    0.000000] Reserved memory: failed to reserve memory
>>  for node 'ibm,firmware-data at 30e00000': base 0x0000000030e00000, size 12 MiB
>> 388204211: (388204206): [    0.000000] Reserved memory: failed to reserve memory
>>  for node 'ibm,firmware-heap at 30200000': base 0x0000000030200000, size 12 MiB
>> 388369776: (388369771): [    0.000000] Reserved memory: failed to reserve memory
>>  for node 'ibm,firmware-code at 30000000': base 0x0000000030000000, size 2 MiB
>> 388534158: (388534153): [    0.000000] Reserved memory: failed to reserve memory
>>  for node 'ibm,firmware-allocs-memory at 39a00000': base 0x0000000039a00000, size 1
>>  MiB
>> 
>> Are ^ the result of trying to reserve it twice?
>
> Yes - the change I've posted adds the node-style reservations alongside
> the property-style reservations. Since current kernels support both,
> we'll get those messages reported.
>
> Ben - if we've supported the node-style reservations in Linux for long
> enough, perhaps we should remove the property-style ones in OPAL?

We should probably go back and pick a "this is the earliest upstream"
and other such variants (such as PowerKVM 2.1) and assemble that
somewhere.



More information about the Skiboot mailing list