[Skiboot] [PATCH] core: Add node-style memory reservation to device tree

[Stewart Smith]

Jeremy Kerr <jk at ozlabs.org> writes:
> Linux supports a newer memory reservation layout in the device-tree,
> where each reservation is represented by a subnode under a top-level
> "reserved-memory" node.
>
> This change adds these nodes, using the mem_region names as the property
> names (minus any cell addresses). The reserved-memory node looks like
> this:
>
> / {
> 	name = "reserved-memory";
> 	ranges;
> 	#address-cells = <0x2>;
> 	#size-cells = <0x2>;
>
> 	ibm,firmware-code at 30000000 {
> 		reg = <0x0 0x30000000 0x0 0x200000>;
> 	};

With this patch I get this with my mambo tests (have zImage.epapr in
~/skiboot and run make check). It seems as though we're getting some
logs about the reserved memory?

14871833: (14871833): [14868998,5] INIT: Loading kernel
14875859: (14875859): [14872142,5] Assuming kernel at 0x20000000
14881057: (14881057): [14876086,5] INIT: Kernel loaded, size: 0 bytes (0 = unkno
wn preload)
14885549: (14885549): [14881346,5] INIT: 32-bit kernel entry at 0x2001015c
14903544: (14903544): [14886769,3] OCC: No HOMER detected, assuming no pstates
14907601: (14907601): [14903797,3] ELOG: Error getting buffer to log error
19603894: (19603894): [19597505,5] INIT: Starting kernel at 0x2001015c, fdt at 0
x30203a78 (size 0x13c8)
382722408: (382722405): [382718055,3] OPAL: Trying a CPU re-init with flags: 0x1
382731228: (382731225): [382723646,3] SLW: Not found on chip 0
382735345: (382735342): [382731481,3] ELOG: Error getting buffer to log error
387826830: (387826825): [    0.000000] OPAL V3 detected !
387871856: (387871851): [    0.000000] Reserved memory: failed to reserve memory
 for node 'ibm,firmware-stacks at 31a00000': base 0x0000000031a00000, size 0 MiB
388038641: (388038636): [    0.000000] Reserved memory: failed to reserve memory
 for node 'ibm,firmware-data at 30e00000': base 0x0000000030e00000, size 12 MiB
388204211: (388204206): [    0.000000] Reserved memory: failed to reserve memory
 for node 'ibm,firmware-heap at 30200000': base 0x0000000030200000, size 12 MiB
388369776: (388369771): [    0.000000] Reserved memory: failed to reserve memory
 for node 'ibm,firmware-code at 30000000': base 0x0000000030000000, size 2 MiB
388534158: (388534153): [    0.000000] Reserved memory: failed to reserve memory
 for node 'ibm,firmware-allocs-memory at 39a00000': base 0x0000000039a00000, size 1
 MiB

Are ^ the result of trying to reserve it twice?

388711270: (388711265): [    0.000000] Using PowerNV machine description
388778417: (388778412): [    0.000000] bootconsole [udbg0] enabled
388839611: (388839606): [    0.000000] CPU maps initialized for 1 thread per cor
e
388924402: (388924397):  -> smp_release_cpus()
388954297: (388954292): spinning_secondaries = 0
388986268: (388986263):  <- smp_release_cpus()
389019235: (389019230): [    0.000000] Starting Linux PPC64 #2 SMP Fri Jan 23 15
:52:55 AEDT 2015
389113000: (389112995): [    0.000000] -----------------------------------------
------------
389202007: (389202002): [    0.000000] ppc64_pft_size                = 0x0
389269246: (389269241): [    0.000000] physicalMemorySize            = 0x4000000
0
389345236: (389345231): [    0.000000] htab_address                  = 0xc000000
03f000000
389430689: (389430684): [    0.000000] htab_hash_mask                = 0x1ffff
389502540: (389502535): [    0.000000] -----------------------------------------
------------
389588423: (389588418):  <- setup_system()
389617776: (389617771): [    0.000000] Linux version 3.17.2 (stewart at ka1) (gcc v
ersion 4.8.3 (Buildroot 2014.08-git-g1455c21) ) #2 SMP Fri Jan 23 15:52:55 AEDT 
2015