[Skiboot] [PATCH 02/12] opal: Identify chip role for a given topology.

Mahesh Jagannath Salgaonkar mahesh at linux.vnet.ibm.com
Tue May 5 21:13:26 AEST 2015


On 04/22/2015 09:34 AM, Stewart Smith wrote:
> Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
>> +static void __print_topo_info(enum chiptod_topology topo)
> 
> Double underscores are reserved for language implementation, we
> shouldn't use them.
> 
>> +{
>> +	const char *role[] = { "Unknown", "MDMT", "MDST", "SDMT", "SDST" };
>> +
>> +	prlog(PR_DEBUG, "CHIPTOD:    chip id: %d\n",
>> +					chiptod_topology_info[topo].id);
>> +	prlog(PR_DEBUG, "CHIPTOD:    Role   : %s\n",
>> +				role[chiptod_topology_info[topo].role + 1]);
> 
> use 1 line for this prlog, not two.
> 

Sure. will fix it.



More information about the Skiboot mailing list