[Skiboot] [PATCH 05/15] FSP/LED: Define macro instead of hardcoding led type

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Mar 31 17:07:16 AEDT 2015

On 03/26/2015 08:55 AM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> Define macors for LED related device tree property and
>> its values.
>> Macros which needs to be exposed to host is defined in opal.h
> I don't think we really need these. convention is that we just use the
> strings around the place and define that in API, so keeping strings
> rather than defines around is fine.


There are multiple places where I refer same string.. Hence converted them to
macros..May be I can move all macros to led.h . .what you say ?


More information about the Skiboot mailing list