[Skiboot] [PATCH 1/2] FSP/EPOW: Depricate OPAL_GET_EPOW_STATUS API

Vipin K Parashar vipin at linux.vnet.ibm.com
Tue Mar 31 02:50:46 AEDT 2015


Depricating OPAL_GET_EPOW_STATUS API as this interface is not used
for getting system EPOW events information. This API provides a complex
interface for getting EPOW events information with lot of redundant
details. Most of these details might not be populated or could be wrongly
populated due to deails not being accurately available from hardware
via EPOW notifications.
	Use OPAL_GET_EPOW_EVENT_INFO API to get EPOW event information.

Signed-off-by: Vipin K Parashar <vipin at linux.vnet.ibm.com>
---
 hw/fsp/Makefile.inc        |  2 +-
 include/fsp.h              |  3 ---
 include/opal.h             | 47 ----------------------------------------------
 platforms/ibm-fsp/common.c |  4 ----
 4 files changed, 1 insertion(+), 55 deletions(-)

diff --git a/hw/fsp/Makefile.inc b/hw/fsp/Makefile.inc
index d4654d5..d9c21e6 100644
--- a/hw/fsp/Makefile.inc
+++ b/hw/fsp/Makefile.inc
@@ -3,7 +3,7 @@ SUBDIRS += hw/fsp
 FSP_OBJS  = fsp.o fsp-console.o fsp-rtc.o fsp-nvram.o fsp-sysparam.o
 FSP_OBJS += fsp-surveillance.o fsp-codeupdate.o fsp-sensor.o
 FSP_OBJS += fsp-diag.o fsp-leds.o fsp-mem-err.o fsp-op-panel.o
-FSP_OBJS += fsp-elog-read.o fsp-elog-write.o fsp-epow.o fsp-dpo.o
+FSP_OBJS += fsp-elog-read.o fsp-elog-write.o fsp-dpo.o
 FSP_OBJS += fsp-dump.o fsp-mdst-table.o
 FSP_OBJS += fsp-attn.o
 FSP = hw/fsp/built-in.o
diff --git a/include/fsp.h b/include/fsp.h
index 66fadb1..260c4e1 100644
--- a/include/fsp.h
+++ b/include/fsp.h
@@ -789,9 +789,6 @@ extern void fsp_init_diag(void);
 extern void fsp_led_init(void);
 extern void create_led_device_nodes(void);
 
-/* EPOW */
-extern void fsp_epow_init(void);
-
 /* DPO */
 extern void fsp_dpo_init(void);
 
diff --git a/include/opal.h b/include/opal.h
index 622e1d5..952000c 100644
--- a/include/opal.h
+++ b/include/opal.h
@@ -390,13 +390,6 @@ enum OpalSlotLedState {
 	OPAL_SLOT_LED_STATE_ON = 1	/* LED is ON */
 };
 
-enum OpalEpowStatus {
-	OPAL_EPOW_NONE = 0,
-	OPAL_EPOW_UPS = 1,
-	OPAL_EPOW_OVER_AMBIENT_TEMP = 2,
-	OPAL_EPOW_OVER_INTERNAL_TEMP = 3
-};
-
 enum OpalCheckTokenStatus {
 	OPAL_TOKEN_ABSENT = 0,
 	OPAL_TOKEN_PRESENT = 1
@@ -450,46 +443,6 @@ struct opal_ipmi_msg {
 	uint8_t data[];
 };
 
-/*
- * EPOW status sharing (OPAL and the host)
- *
- * The host will pass on OPAL, a buffer of length OPAL_SYSEPOW_MAX
- * with individual elements being 16 bits wide to fetch the system
- * wide EPOW status. Each element in the buffer will contain the
- * EPOW status in it's bit representation for a particular EPOW sub
- * class as defiend here. So multiple detailed EPOW status bits
- * specific for any sub class can be represented in a single buffer
- * element as it's bit representation.
- */
-
-/* System EPOW type */
-enum OpalSysEpow {
-	OPAL_SYSEPOW_POWER	= 0,	/* Power EPOW */
-	OPAL_SYSEPOW_TEMP	= 1,	/* Temperature EPOW */
-	OPAL_SYSEPOW_COOLING	= 2,	/* Cooling EPOW */
-	OPAL_SYSEPOW_MAX	= 3,	/* Max EPOW categories */
-};
-
-/* Power EPOW */
-enum OpalSysPower {
-	OPAL_SYSPOWER_UPS	= 0x0001, /* System on UPS power */
-	OPAL_SYSPOWER_CHNG	= 0x0002, /* System power configuration change */
-	OPAL_SYSPOWER_FAIL	= 0x0004, /* System impending power failure */
-	OPAL_SYSPOWER_INCL	= 0x0008, /* System incomplete power */
-};
-
-/* Temperature EPOW */
-enum OpalSysTemp {
-	OPAL_SYSTEMP_AMB	= 0x0001, /* System over ambient temperature */
-	OPAL_SYSTEMP_INT	= 0x0002, /* System over internal temperature */
-	OPAL_SYSTEMP_HMD	= 0x0004, /* System over ambient humidity */
-};
-
-/* Cooling EPOW */
-enum OpalSysCooling {
-	OPAL_SYSCOOL_INSF	= 0x0001, /* System insufficient cooling */
-};
-
 /* FSP memory errors handling */
 enum OpalMemErr_Version {
 	OpalMemErr_V1 = 1,
diff --git a/platforms/ibm-fsp/common.c b/platforms/ibm-fsp/common.c
index da1da5a..a4e9903 100644
--- a/platforms/ibm-fsp/common.c
+++ b/platforms/ibm-fsp/common.c
@@ -147,10 +147,6 @@ void ibm_fsp_init(void)
 	fsp_code_update_init();
 
 	/* EPOW */
-	op_display(OP_LOG, OP_MOD_INIT, 0x000A);
-	fsp_epow_init();
-
-	/* EPOW */
 	op_display(OP_LOG, OP_MOD_INIT, 0x000B);
 	fsp_dpo_init();
 
-- 
1.9.3



More information about the Skiboot mailing list