[Skiboot] [PATCH v3 3/3] powerpc/powernv: remove opal_sensor_mutex

Michael Ellerman mpe at ellerman.id.au
Mon Mar 30 13:09:58 AEDT 2015


On Fri, 2015-03-27 at 17:39 +0100, C├ędric Le Goater wrote:
> The opal sensor mutex protects the opal_sensor_read call which
> can return a OPAL_BUSY code on IBM Power systems if a previous 
> request is in progress.
> 
> This can be handled at user level with a retry.

It can, but how does it actually look in practice?

It looks like the only use of opal_get_sensor_data() is show_sensor() in
drivers/hwmon/ibmpowernv.c.

Because that's a sysfs attribute folks will be generally just dumping that with
cat, or reading it in a shell script, neither of which will cope nicely with
EBUSY I think?

cheers




More information about the Skiboot mailing list