[Skiboot] [RFC PATCH 2/2] libflash/file: add file abstraction for libflash

[Daniel Axtens]

Hi Cyril,

There are some really minor comments below. Once they're addressed, I'm
happy to give it a Reviewed-by.


> diff --git a/libflash/file_flash.c b/libflash/file_flash.c
> new file mode 100644
> index 0000000..d902672
> --- /dev/null
> +++ b/libflash/file_flash.c
> @@ -0,0 +1,224 @@
This probably needs some boilerplate with copyright?


> +
> +/* The caller is going to have to supply this */
The what is what now? I think you're trying to say that on setup
(build_flash_ctrl), a file descriptor has to be provided. (Which, as I
understand it, is pretty much implied by the build_flash_ctrl prototype
anyway.)
> +struct file_flash_priv {
> +	int fd;
> +};+



> diff --git a/libflash/file_flash.h b/libflash/file_flash.h
This will probably also need copyright boilerplate.

> new file mode 100644
> index 0000000..dc6b5d7
> --- /dev/null
> +++ b/libflash/file_flash.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 860 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20150326/e5f61210/attachment.sig>