[Skiboot] [PATCH v2 4/5] hwmon: (ibmpowernv) change create_hwmon_attr_name() prototype
Guenter Roeck
linux at roeck-us.net
Sat Mar 21 02:27:02 AEDT 2015
On Fri, Mar 20, 2015 at 09:06:38AM +0100, Cedric Le Goater wrote:
> [ ... ]
>
>
> > @@ -265,10 +261,17 @@ static int create_device_attrs(struct pl
> >
> > sdata[count].id = sensor_id;
> > sdata[count].type = type;
> > - err = create_hwmon_attr_name(&pdev->dev, type, np->name,
> > - sdata[count].name);
> > - if (err)
> > +
> > + attr_name = parse_opal_node_name(np->name, type, &opal_index);
> > + if (IS_ERR(attr_name)) {
> > + dev_err(&pdev->dev, "Sensor device node name '%s' is invalid\n",
> > + np->name);
> > + err = IS_ERR(attr_name);
> ^^^^^^
>
> Arg. Bad copy/paste. This should be PTR_ERR() ...
>
> Do you want a full patchset resend or just a resend of this patch ? or a fix maybe.
>
No need to resend; I fixed it up.
Thanks,
Guenter
More information about the Skiboot
mailing list