[Skiboot] [PATCH 00/15] FSP/LED: Add System Attention Indicator support

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Mar 20 23:04:43 AEDT 2015

This patchset adds System Attention Indicator (SAI) and LED mode support
in OPAL.

LED mode:
  FSP based system can work on two LED modes:
   Light Path   : Both identify and fault LEDs are supported
   Guiding Light: Only identify LEDs are supported

  FSP sends LED mode information via HDAT. We use this information during
  LED device tree node creation. We only expose relavent LEDs to host.

  Patch 9, detects LED mode and patch 10 fixes device tree.

System Attention Indicator:
  Unlike other indicators, this indicator is controlled by FSP. FSP sends
  this indicator details to OPAL via HDAT. We parse HDAT to get location
  code. (patch 11 does this job).

  During LED init get use MBOX command to get LED state. Later anytime
  FSP updates this LED we get system parameter update notification. We
  use that to update cached data. Lastly we use MBOX command to send
  LED update request to FSP. (patch 13).

System paratemer update notifier:
  Patch 14 adds new System paratemer update notifier. So interested
  clients (like LED) can register to these notifier and get update

 On 830 FW, SLCA (part of HDAT) is not giving right SAI location code. I
 have request FSP folks to look into this issue. On 810 FW, it working

@Stewart, Ben,
  I need some clarification on Attn MBOX command. They have real, virtual
  attn LEDs. I'm not sure which one we should use. Currently I have used
  platform virtual SA indicator and it seems to be working. Once I get
  clarification from FSP folks, I may update these commands (patch 13).
  Rest of the patches are fine.


Vasant Hegde (15):
      FSP/LED: Move led header file to include directory
      FSP: Serialize FSP MBOX command declaration
      FSP/LED: Continue processing LED update request in error path
      FSP/LED: Validate before creating LED nodes
      FSP/LED: Define macro instead of hardcoding led type
      OPAL: Validate before creating opal device tree node
      FSP/LED: Validate before creating led node
      hdata: Create LED node
      hdata: Detect LED mode and populate device tree
      FSP/LED: Use LED mode information
      FSP/hdata: Populate System Attention Indicator location code
      FSP/LED: Get SAI location code from device tree
      FSP/LED: Add System attention indicator support
      FSP/SYSPARAM: Introduce update notify system parameter notifier
      FSP/LED: Handle SA indicator update notification

 core/opal.c                               |    6 -
 doc/device-tree/ibm,opal/led.txt          |    3 
 doc/opal-api/opal-led-get-set-114-115.txt |   19 ++
 hdata/hdata.h                             |    1 
 hdata/slca.c                              |   78 ++++++++
 hdata/spira.c                             |   36 ++++
 hdata/spira.h                             |    2 
 hw/fsp/fsp-leds.c                         |  297 +++++++++++++++++++++++++++--
 hw/fsp/fsp-leds.h                         |  153 ---------------
 hw/fsp/fsp-sysparam.c                     |   53 +++++
 include/fsp-leds.h                        |  166 ++++++++++++++++
 include/fsp-sysparam.h                    |    5 
 include/fsp.h                             |   46 +++-
 include/opal.h                            |   16 +-
 14 files changed, 688 insertions(+), 193 deletions(-)
 delete mode 100644 hw/fsp/fsp-leds.h
 create mode 100644 include/fsp-leds.h


More information about the Skiboot mailing list