[Skiboot] [PATCH] PHB3: Do not release unhold lock in error path

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Mar 12 17:14:51 AEDT 2015


..which will result lock error in OPAL.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/phb3.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/phb3.c b/hw/phb3.c
index 67b97cd..e7127bc 100644
--- a/hw/phb3.c
+++ b/hw/phb3.c
@@ -2183,7 +2183,7 @@ static int64_t capp_lid_download(struct phb3 *p)
 	if (rc) {
 		prerror("CAPP: Error reading cfam chip-id\n");
 		ret = OPAL_HARDWARE;
-		goto end;
+		return ret;
 	}
 	/* Keep ChipID and Major/Minor EC.  Mask out the Location Code. */
 	index = index & 0xf0fff;



More information about the Skiboot mailing list