[Skiboot] [PATCH 2/2] FSP: Introduce busy flag in fsp_fetch_data

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Mar 12 07:20:32 AEDT 2015


On Wed, 2015-03-11 at 18:07 +0530, Vasant Hegde wrote:
> +       lock(&fsp_fetch_lock);
> +       fetch_data_busy = false;
> +       unlock(&fsp_fetch_lock);
> +
> +       return rc;
> +}

That lock is useless. Just use a lwsync (or a sync) before the store.

Cheers,
Ben.




More information about the Skiboot mailing list