[Skiboot] [PATCH v2 1/9] Revert "opal: Handle more TFAC errors."

Mahesh J Salgaonkar mahesh at linux.vnet.ibm.com
Wed Mar 11 21:29:11 AEDT 2015


From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>

This reverts commit 699c433a8c736f44b13b7ba28cc0f9e0ac55840c.

The rest of the patches in this series refactors the code that reset TB
errors for better handling/recovery of individual TB errors. Hence Reverting
old patch that claimed to handle more TFAC errors, but did not.

Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
---
 hw/chiptod.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/chiptod.c b/hw/chiptod.c
index 49b84e7..edf805d 100644
--- a/hw/chiptod.c
+++ b/hw/chiptod.c
@@ -311,8 +311,6 @@ static bool chiptod_reset_tb_errors(void)
 	tfmr |= SPR_TFMR_TB_MISSING_SYNC;
 	tfmr |= SPR_TFMR_TB_MISSING_STEP;
 	tfmr |= SPR_TFMR_TB_RESIDUE_ERR;
-	tfmr |= SPR_TFMR_FW_CONTROL_ERR;
-	tfmr |= SPR_TFMR_CHIP_TOD_PARITY_ERR;
 	mtspr(SPR_TFMR, tfmr);
 
 	/* We have to write "Clear TB Errors" again */
@@ -667,9 +665,6 @@ int chiptod_recover_tb_errors(void)
 	 * clear it.
 	 */
 	if ((tfmr & SPR_TFMR_TB_MISSING_STEP) ||
-		(tfmr & SPR_TFMR_TB_RESIDUE_ERR) ||
-		(tfmr & SPR_TFMR_FW_CONTROL_ERR) ||
-		(tfmr & SPR_TFMR_CHIP_TOD_PARITY_ERR) ||
 		(tfmr & SPR_TFMR_TB_MISSING_SYNC)) {
 		if (!chiptod_reset_tb_errors()) {
 			rc = 0;



More information about the Skiboot mailing list