[Skiboot] [PATCH] OCC/hostservices: Call abort if hbrt_lid_list is empty

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Mar 10 17:23:35 AEDT 2015


Call abort if OCC LID preload fails.

Related discussion:
https://lists.ozlabs.org/pipermail/skiboot/2015-March/000636.html

Suggested-by: Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 core/hostservices.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/hostservices.c b/core/hostservices.c
index 22d34e4..76b502d 100644
--- a/core/hostservices.c
+++ b/core/hostservices.c
@@ -486,8 +486,10 @@ static int hservice_lid_load(uint32_t lid, void **buf, size_t *len)
 
 	prlog(PR_INFO, "HBRT: Lid load request for 0x%08x\n", lid);
 
-	if (list_empty(&hbrt_lid_list))	/* Should not happen */
-		hservices_lid_preload();
+	if (list_empty(&hbrt_lid_list))	{ /* Should not happen */
+		prlog(PR_CRIT, "HBRT: LID Load failed\n");
+		abort();
+	}
 
 	list_for_each(&hbrt_lid_list, hlid, link) {
 		if (hlid->id == lid) {



More information about the Skiboot mailing list