[Skiboot] [PATCH] OCC: Do not call occ_do_load if hostservice LID load is not complete
Vasant Hegde
hegdevasant at linux.vnet.ibm.com
Mon Mar 9 18:47:54 AEDT 2015
On 03/09/2015 12:09 PM, Vaidyanathan Srinivasan wrote:
> * Vasant Hegde <hegdevasant at linux.vnet.ibm.com> [2015-03-09 11:56:53]:
>
.../...
>>
>> __occ_do_load(scope, dbob_id, seq_id);
>
> This will get called from occ_poke_load_queue() after lid preload is
> complete.
>
> In addition to this fix,
>
> hservice_lid_load()
> if (list_empty(&hbrt_lid_list)) /* Should not happen */
> hservices_lid_preload(); <<, Change to abort()
Vaidy,
So you don't want to try loading LID again here?
Also better return error instead of abort?
-Vasant
>
> If we come back via hostservices and find lid not preloaded, then we
> abort. The preload should happen first and also be preserved for any
> runtime reload.
>
> --Vaidy
>
More information about the Skiboot
mailing list