[Skiboot] [PATCH] OCC: Fix possible memory leak in error path

[Vasant Hegde]

On 03/08/2015 09:11 PM, Neelesh Gupta wrote:
> 
> On 03/08/2015 03:16 PM, Vasant Hegde wrote:
>> free fsp_msg if fsp_queue_msg fails.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> ---
>>   hw/occ.c |    5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/occ.c b/hw/occ.c
>> index 657f2ad..b523a42 100644
>> --- a/hw/occ.c
>> +++ b/hw/occ.c
>> @@ -409,6 +409,7 @@ static void __occ_do_load(u8 scope, u32 dbob_id __unused,
>> u32 seq_id)
>>       if (rc) {
>>           log_simple_error(&e_info(OPAL_RC_OCC_LOAD),
>>               "OCC: Error %d queueing FSP OCC LOAD STATUS msg", rc);
>> +        free(stat);
> 
> fsp_freemsg() should be used instead, to avoid leaking 'msg->resp'
> Same at the other places below.

Yep.. You are right.. Fixed in v2.

-Vasant