[Skiboot] [PATCH 2/2] fsp/rtc: Introduce the rtc write state machine

Neelesh Gupta neelegup at linux.vnet.ibm.com
Sat Mar 7 16:14:01 AEDT 2015

On 03/07/2015 10:34 AM, Neelesh Gupta wrote:
> Similar to rtc read requests, have a state machine to handle the
> write transitions.

Hi Stewart,

The rtc write is broken currently with the latest skiboot, as we never 
OPAL_SUCCESS in the opal rtc write call. This patch fixes this issue.

Moreover, I think it is good to have the state machine for write as well 
to what you added for read transitions..  also update the opal pending 
event bit
by differentiating between rtc request state for read and write separately..


> Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>
> ---
>   hw/fsp/fsp-rtc.c |  118 ++++++++++++++++++++++++++++++++++--------------------
>   1 file changed, 74 insertions(+), 44 deletions(-)

More information about the Skiboot mailing list