[Skiboot] [PATCH v2] LEDS: Rename led node as leds

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Jun 26 20:38:55 AEST 2015


Presently we are creating '/ibm,opal/led' node and populating all LED
related information there. Ben [1] suggested to rename this as 'leds'.

Present code is included in skiboot skiboot-5.0 release..But we don't
have any consumer yet. Hence I think its fine to make this changes.

Finally updated node name in doc file.

[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-June/130433.html

Suggested-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 doc/device-tree/ibm,opal/led.txt |    6 +++---
 include/fsp-leds.h               |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/device-tree/ibm,opal/led.txt b/doc/device-tree/ibm,opal/led.txt
index 2ce6946..00cd32c 100644
--- a/doc/device-tree/ibm,opal/led.txt
+++ b/doc/device-tree/ibm,opal/led.txt
@@ -1,10 +1,10 @@
 Service Indicators (LEDS)
 -------------------------
 
-The 'led' node under 'ibm,opal' lists service indicators available in the
+The 'leds' node under 'ibm,opal' lists service indicators available in the
 system and their capabilities.
 
-led {
+leds {
 	compatible = "ibm,opal-v3-led";
 	phandle = <0x1000006b>;
 	linux,phandle = <0x1000006b>;
@@ -24,7 +24,7 @@ led {
 
 'led-mode' property describes service indicator mode (lightpath/guidinglight).
 
-Each node under 'led' node describes location code of FRU/Enclosure.
+Each node under 'leds' node describes location code of FRU/Enclosure.
 
 The properties under each node:
 
diff --git a/include/fsp-leds.h b/include/fsp-leds.h
index 1b99ffc..dcf30b1 100644
--- a/include/fsp-leds.h
+++ b/include/fsp-leds.h
@@ -158,7 +158,7 @@ struct sai_data {
 
 /* LED Device tree property names */
 #define DT_PROPERTY_LED_COMPATIBLE	"ibm,opal-v3-led"
-#define DT_PROPERTY_LED_NODE		"led"
+#define DT_PROPERTY_LED_NODE		"leds"
 #define DT_PROPERTY_LED_MODE		"led-mode"
 #define DT_PROPERTY_LED_TYPES		"led-types"
 #define DT_PROPERTY_LED_LOCATION	"led-loc"



More information about the Skiboot mailing list