[Skiboot] [PATCH 2/8] queue_led_state_change() - Fix unterminated string warning

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Jun 24 15:58:24 AEST 2015

On 06/23/2015 02:07 PM, Kamalesh Babulal wrote:
> struct led_set_cmd cmd is zalloc. While doing strncpy of
> loc_code to cmd->loc_code, there are chances of cmd->loc_code
> being unterminated. Fix the issue by copying LOC_CODE_SIZE - 1.
> Fixes Coverity defect #100249.
> Signed-off-by: Kamalesh Babulal <kamalesh at linux.vnet.ibm.com>
> Cc: Ananth N Mavinakayanahalli <ananth at in.ibm.com>
> Cc: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


More information about the Skiboot mailing list