[Skiboot] [PATCH] cpu: Fix hang issue in opal_reinit_cpus()
stewart at linux.vnet.ibm.com
Tue Jun 16 16:37:53 AEST 2015
Hari Bathini <hbathini at linux.vnet.ibm.com> writes:
> Commit 87690bd19dbb introduced a label "again" so as to avoid holding
> the lock while waiting. But this leads to hang in scenarios like kdump,
> where 'cpu_state_os' will be the state for all offline cpus. Actaully,
> the wait loop doesn't really take off with the goto statement in it.
> This patch tries to fix this problem by removing the goto statement
> and unlocking/locking within the wait loop instead.
So... I'm going to merge this but I'd love it if we could think of a way
to enable us to do the switch just in case for some (stupid) reason
kdump kernel is different endian.
We should *document* this though, so I'm looking forward to a patch to
doc/opal-api/opal-reinit-cpus-70.txt from you :)
More information about the Skiboot