[Skiboot] [PATCH 2/2] p8-i2c: Ensure request "result" field is updated on completion

Benjamin Herrenschmidt benh at au1.ibm.com
Tue Jun 16 11:04:29 AEST 2015

It may or may not already contain the right error code (it can be
used internally by the state machine to carry the error accross the
recovery state), but in case where it's not, update it.

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
 hw/p8-i2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/p8-i2c.c b/hw/p8-i2c.c
index 3cc01bb..510604a 100644
--- a/hw/p8-i2c.c
+++ b/hw/p8-i2c.c
@@ -390,6 +390,7 @@ static void p8_i2c_complete_request(struct p8_i2c_master *master,
 	master->state = state_idle;
+	req->result = ret;
 	/* Schedule re-enabling of sensor cache */
 	if (master->occ_cache_dis)

More information about the Skiboot mailing list