[Skiboot] [PATCH 3/7] libflash/blocklevel: add blocklevel flags.

Alistair Popple alistair at popple.id.au
Fri Jun 12 12:15:07 AEST 2015


Looks ok to me.

Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Fri, 5 Jun 2015 14:11:27 Cyril Bur wrote:
> @@ -48,6 +53,7 @@ struct blocklevel_device {
>  
>  	struct bl_prot_range *write_prot;
>  	int n_write_prot;
> +

I'll be a pedant and say we don't need this change...

>  };
>  
>  int blocklevel_read(struct blocklevel_device *bl, uint32_t pos, void *buf, uint32_t len);
> diff --git a/libflash/libflash.c b/libflash/libflash.c
> index a142e17..55eafbe 100644
> --- a/libflash/libflash.c
> +++ b/libflash/libflash.c
> @@ -838,6 +838,7 @@ bail:
>  	c->bl.erase = &flash_erase;
>  	c->bl.get_info = &flash_get_info;
>  	c->bl.erase_mask = c->min_erase_mask;
> +	c->bl.flags = WRITE_NEED_ERASE;
>  
>  	*bl = &(c->bl);
>  	return 0;
> 



More information about the Skiboot mailing list