[Skiboot] [PATCH 2/2] hdata/memory: Add dimm frequency information

Neelesh Gupta neelegup at linux.vnet.ibm.com
Tue Jun 2 15:57:53 AEST 2015


Fetch the memory bus frequency present in PCIA area and add this
information to the memory node.

ms-dimm at d000 {
	[...]
	description = "32GB CDIMM";
	ibm,loc-code = "U78C9.001.WZS03HU-P1-C16";
	ibm,memory-bus-frequency = <0x0 0x5f5e1000>;
	serial-number = "YH10M147C1L1";
	fru-type = [4d 53];
	[...]
};

Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---

v2 -> v3
- Improve the documentation as per Stewart's suggestion.

v1 -> v2
- Document the new property 'ibm,memory-bus-frequency' under DIMM
  VPD node.

 doc/device-tree/vpd.txt |    1 +
 hdata/memory.c          |   54 +++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 53 insertions(+), 2 deletions(-)

diff --git a/doc/device-tree/vpd.txt b/doc/device-tree/vpd.txt
index 71c2e61..a2c5e63 100644
--- a/doc/device-tree/vpd.txt
+++ b/doc/device-tree/vpd.txt
@@ -18,6 +18,7 @@ part-number		: Part number
 serial-number		: Serial number
 ibm,chip-id		: Processor Id
 size			: DIMM size (applicable for DIMM VPD only)
+ibm,memory-bus-frequency: DIMM frequency (applicable for DIMM VPD only)
 
 The VPD tree in the device tree depicts the hierarchial structure of the
 FRUs having parent-child relationship.
diff --git a/hdata/memory.c b/hdata/memory.c
index 019e5fe..352dc71 100644
--- a/hdata/memory.c
+++ b/hdata/memory.c
@@ -159,7 +159,7 @@ static bool add_address_range(struct dt_node *root,
 	return true;
 }
 
-static void add_chip_id_to_ram_area(const struct HDIF_common_hdr *msarea,
+static u32 add_chip_id_to_ram_area(const struct HDIF_common_hdr *msarea,
 				    struct dt_node *ram_area)
 {
 	const struct HDIF_array_hdr *arr;
@@ -172,6 +172,53 @@ static void add_chip_id_to_ram_area(const struct HDIF_common_hdr *msarea,
 	arange = (void *)arr + be32_to_cpu(arr->offset);
 	chip_id = pcid_to_chip_id(be32_to_cpu(arange->chip));
 	dt_add_property_cells(ram_area, "ibm,chip-id", chip_id);
+
+	return chip_id;
+}
+
+static void add_bus_freq_to_ram_area(struct dt_node *ram_node, u32 chip_id)
+{
+	const struct sppcia_cpu_timebase *timebase;
+	bool got_pcia = false;
+	const void *pcia;
+	u64 freq;
+	u32 size;
+
+	pcia = get_hdif(&spira.ntuples.pcia, SPPCIA_HDIF_SIG);
+	if (!pcia) {
+		prlog(PR_WARNING, "HDAT: Failed to add memory bus frequency "
+		      "as PCIA does not exist\n");
+		return;
+	}
+
+	for_each_pcia(pcia) {
+		const struct sppcia_core_unique *id;
+
+		id = HDIF_get_idata(pcia, SPPCIA_IDATA_CORE_UNIQUE, &size);
+		if (!id || size < sizeof(*id)) {
+			prlog(PR_WARNING, "HDAT: Bad id size %u @ %p\n", size, id);
+			return;
+		}
+
+		if (chip_id == pcid_to_chip_id(be32_to_cpu(id->proc_chip_id))) {
+			got_pcia = true;
+			break;
+		}
+	}
+
+	if (got_pcia == false)
+		return;
+
+	timebase = HDIF_get_idata(pcia, SPPCIA_IDATA_TIMEBASE, &size);
+	if (!timebase || size < sizeof(*timebase)) {
+		prlog(PR_ERR, "HDAT: Bad timebase size %u @ %p\n", size,
+		      timebase);
+		return;
+	}
+
+	freq = ((u64)be32_to_cpu(timebase->memory_bus_frequency)) *1000000ul;
+	dt_add_property_cells(ram_node, "ibm,memory-bus-frequency", hi32(freq),
+			      lo32(freq));
 }
 
 static void add_size_to_ram_area(struct dt_node *ram_node,
@@ -207,6 +254,7 @@ static void vpd_add_ram_area(const struct HDIF_common_hdr *msarea)
 	const struct HDIF_child_ptr *ramptr;
 	const struct HDIF_ram_area_id *ram_id;
 	struct dt_node *ram_node;
+	u32 chip_id;
 
 	ramptr = HDIF_child_arr(msarea, 0);
 	if (!CHECK_SPPTR(ramptr)) {
@@ -227,7 +275,9 @@ static void vpd_add_ram_area(const struct HDIF_common_hdr *msarea)
 		    (be16_to_cpu(ram_id->flags) & RAM_AREA_FUNCTIONAL)) {
 			ram_node = dt_add_vpd_node(ramarea, 0, 1);
 			if (ram_node) {
-				add_chip_id_to_ram_area(msarea, ram_node);
+				chip_id = add_chip_id_to_ram_area(msarea,
+								  ram_node);
+				add_bus_freq_to_ram_area(ram_node, chip_id);
 				add_size_to_ram_area(ram_node, ramarea, 1);
 			}
 		}



More information about the Skiboot mailing list