[Skiboot] [PATCH 1/3] errorlog: Simplify log calling convention
hegdevasant at linux.vnet.ibm.com
Wed Jul 29 20:29:56 AEST 2015
On 07/28/2015 10:01 AM, Samuel Mendoza-Jonas wrote:
> Remove the callback functionality from log_error() and replace it with
> the ability to append to a user data section, or add addtional user
> data sections to an error log.
> For multiline or otherwise complex logging the convention is now to call
> opal_elog_create() to obtain a errorlog buffer and use log_append_msg()
> and log_append_data() to append to the user data section. Additional
> user data sections can be added to the error log via log_add_section().
> The caller is then responsible for calling log_commit().
> For simple logs log_simple_error() takes care of creating and committing
> the error log as before.
> Signed-off-by: Samuel Mendoza-Jonas <sam.mj at au1.ibm.com>
I've gone through the patch. Looks good.
Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
More information about the Skiboot