[Skiboot] [PATCH v3 2/2] doc/opal-api: Add OPAL_CEC_REBOOT2 OPAL call description

[Kamalesh Babulal]

On 07/28/2015 11:36 PM, Mahesh J Salgaonkar wrote:
> From: Vipin K Parashar <vipin at linux.vnet.ibm.com>
>
> This patch adds doc/opal-api/opal-cec-reboot-6-116.txt file
> to add description for OPAL_CEC_REBOOT* OPAL call.
>
> Signed-off-by: Vipin K Parashar <vipin at linux.vnet.ibm.com>
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
>  doc/opal-api/opal-cec-reboot-6-116.txt |   55 ++++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 doc/opal-api/opal-cec-reboot-6-116.txt
>
> diff --git a/doc/opal-api/opal-cec-reboot-6-116.txt b/doc/opal-api/opal-cec-reboot-6-116.txt
> new file mode 100644
> index 0000000..6f6be11
> --- /dev/null
> +++ b/doc/opal-api/opal-cec-reboot-6-116.txt
> @@ -0,0 +1,55 @@
> +OPAL_CEC_REBOOT and OPAL_CEC_REBOOT2
> +------------------------------------
> +
> +#define OPAL_CEC_REBOOT		6
> +#define OPAL_CEC_REBOOT2	116
> +

Minor nit picks, alignment of macro
> +There are two opal calls to invoke system reboot.
> +OPAL_CEC_REBOOT: Used for normal reboot by linux host.

s/linux/Linux

> +
> +OPAL_CEC_REBOOT2: Newly introduced to handle abnormal system reboots.
> +The Linux kernel will make this OPAL call when it has to terminate
> +abruptly due to an anomalous condition. The kernel will push some system
> +state context to OPAL, which will in turn push it down to the BMC for
> +further analysis.
> +
> +OPAL_CEC_REBOOT
> +---------------
> +Syntax:
> +int64_t opal_cec_reboot(void)
> +
> +Input parameters:
> +None.
> +
> +System reboots normally.
> +
> +OPAL_CEC_REBOOT2
> +----------------
> +Syntax:
> +int64_t opal_cec_reboot2(uint32_t reboot_type, uint64_t diag, uint64_t size)
> +
> +Input parameters:
> +	@reboot_type	Type of reboot. (see below)
> +	@diag		Pointer to buffer containing debug information.
> +	@size		Size of the diag buffer.
> +
> +Depending on reboot type the this call will carry out additional steps

s/the this/, this/

> +before triggering reboot.
> +

-- 
Cheers,
Kamalesh.