[Skiboot] [RESEND PATCH v1 04/11]ibm-fsp/firenze: DT entry for DIMM rate

Madhavan Srinivasan maddy at linux.vnet.ibm.com
Thu Jul 16 13:30:27 AEST 2015



On Thursday 16 July 2015 07:26 AM, Joel Stanley wrote:
> On Sun, 2015-07-05 at 22:25 +0530, Madhavan Srinivasan wrote:
>> diff --git a/hw/nest.c b/hw/nest.c
>> index 7b13512..1798351 100644
>> --- a/hw/nest.c
>> +++ b/hw/nest.c
>> @@ -148,5 +148,21 @@ void nest_ima_init(void)
>>  		dt_add_property_cells(chip_dev, "size", SLW_IMA_SIZE);
>>  		dt_add_property(chip_dev, "ibm,ima-chip", NULL, 0);
>>  	}
>> +
>> +	/*
>> +	 * Dimm rate DT Entry. Needed for % utilisation calculation.
>> +	 */
>> +	chip = get_chip(pir_to_chip_id(this_cpu()->pir));
> get_chip(this_cpu()->chip_id)

Yes.  Will change it.

>
>> +	switch (chip->type) {
>> +	case PROC_CHIP_P8_MURANO:
>> +		dt_add_property_cells(dev,"dimm", MURANO_CENTAUR_DIMM);
>> +		break;
>> +	case PROC_CHIP_P8_VENICE:
>> +		dt_add_property_cells(dev,"dimm", VENICE_CENTAUR_DIMM);
>> +		break;
>> +	default:
> Print a warning?

Yes. Make sense. Will add a warning

> How about naples?

Yes. Right.  Will add it.
Nice catch. Thanks

>> +		break;
>> +	}
>> +
>>  	return;
>>  }
>



More information about the Skiboot mailing list