[Skiboot] [PATCH 3/3] p7ioc-phb: Remove logically deadcode

Kamalesh Babulal kamalesh at linux.vnet.ibm.com
Sat Jul 11 01:25:48 AEST 2015


We exit p7ioc_phb_mmio_enable(), with OPAL_PARAMETER. When enable is
>= OPAL_ENABLE_M64_NON_SPLIT. So remove the logically dead code, which
handles this condition.

Fixes Coverity defect#97826.

Signed-off-by: Kamalesh Babulal <kamalesh at linux.vnet.ibm.com>
---
 hw/p7ioc-phb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/p7ioc-phb.c b/hw/p7ioc-phb.c
index 0b37993..74083e4 100644
--- a/hw/p7ioc-phb.c
+++ b/hw/p7ioc-phb.c
@@ -1711,8 +1711,6 @@ static int64_t p7ioc_phb_mmio_enable(struct phb *phb,
 		data64 |= IODA_M64BT_ENABLE;
 	} else if (enable == OPAL_DISABLE_M64) {
 		data64 &= ~IODA_M64BT_ENABLE;
-	} else
-		return OPAL_PARAMETER;
 
 	p7ioc_phb_ioda_sel(p, IODA_TBL_M64BT, window_num, false);
 	out_be64(p->regs + PHB_IODA_DATA0, data64);
-- 
2.1.2



More information about the Skiboot mailing list