[Skiboot] [RESEND PATCH v1 00/11] OPAL support for Nest instrumentation

Benjamin Herrenschmidt benh at kernel.crashing.org
Mon Jul 6 05:58:14 AEST 2015


On Sun, 2015-07-05 at 22:25 +0530, Madhavan Srinivasan wrote:
> Patchset adds support for Nest instrumentation services
> in OPAL. Power8 has Nest instrumentation enabled with which
> per-chip metrics like memory bandwidth, Powerbus, X link and
> A link metrics can be obtained.

Why is it all in ibm-fsp/firenze ? This is P8 chip specific, not
FSP machine specific, right ? There is no reason this cannot be
made to work on Open Power machines is there ?

> Patchset does two things,1) At the time of boot, it detects
> the Nest instrumentation feature and created device-tree
> entries to pass the information to kernel. Secondly, it
> implements an opal call to control the PORE Thread Scheduler
> (PTS) from kernel to start/stop Nest PMU counter collection.
> Patchset tested only in IBM Tuleta boxes.
> 
> Change log v1:
> 
> 1) Removed "uncore" naming and replaced it with "nest/ima" in all the
>   file and function.
> 2) Added a DT entry to pass DIMM rate information
> 3) Added nest instrumentation detection code and catalog parser function
> 4) Added support functions for different nest units.
> 
> Kindly let me know your comments and feedback.
> 
> Madhavan Srinivasan (11):
>  ibm-fsp/firenze: nest data structure definitions
>  ibm-fsp/firenze: nest feature detection
>  ibm-fsp/firenze: DT entry for per-chip HOMER offset
>  ibm-fsp/firenze: DT entry for DIMM rate
>  ibm-fsp/firenze: Nest unit parser function
>  ibm-fsp/firenze: Nest MCS unit support
>  ibm-fsp/firenze: Nest PowerBus unit support
>  ibm-fsp/firenze: Nest Alink unit support
>  ibm-fsp/firenze: Nest Xlink unit support
>  ibm-fsp/firenze: Add OPAL call to enable/disable Nest pmu
>  ibm-fsp/firenze: Add init function call to involve Nest support
> 
>  core/init.c        |   4 +
>  hw/Makefile.inc    |   2 +-
>  hw/fsp/fsp.c       |   3 +
>  hw/nest.c          | 451 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/mem-map.h  |   2 +
>  include/nest.h     | 244 +++++++++++++++++++++++++++++
>  include/opal-api.h |   3 +-
>  include/platform.h |   1 +
>  include/types.h    |   1 +
>  9 files changed, 709 insertions(+), 2 deletions(-)
>  create mode 100644 hw/nest.c
>  create mode 100644 include/nest.h
> 




More information about the Skiboot mailing list