[Skiboot] [PATCH] i2c: Do not read the 'ibm,port-name' property

Neelesh Gupta neelegup at linux.vnet.ibm.com
Fri Jan 30 20:09:42 AEDT 2015


The skiboot does not rely on the i2c bus property 'ibm,port-name'
and is useful for the Linux. Currently, the i2c driver reads this
property for logging purpose, but leads to skiboot crash if the
property is not present, so just don't read it.

Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>
---
 hw/p8-i2c.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/p8-i2c.c b/hw/p8-i2c.c
index 3e5334c..1717182 100644
--- a/hw/p8-i2c.c
+++ b/hw/p8-i2c.c
@@ -1201,10 +1201,10 @@ void p8_i2c_init(void)
 			port->bus.alloc_req = p8_i2c_alloc_request;
 			port->bus.free_req = p8_i2c_free_request;
 			i2c_add_bus(&port->bus);
-			prlog(PR_INFO, " P%d: <%s> %d kHz\n",
-			      port->port_num,
-			      (char *)dt_prop_get(i2cm_port, "ibm,port-name"),
-			      speed/1000);
+			prlog(PR_INFO, "I2C: chip(0x%02x)-engine(%d)-port(%d) "
+				       "@ %d kHz\n", master->chip_id,
+						     master->engine_id,
+						     port->port_num, speed/1000);
 			port++;
 		}
 



More information about the Skiboot mailing list