[Skiboot] [PATCH 1/3] ipmi: Add a function to (re)initialise a message without allocation

Alistair Popple alistair at popple.id.au
Wed Jan 28 18:30:23 AEDT 2015


On Wed, 28 Jan 2015 16:40:05 Stewart Smith wrote:
> Alistair Popple <alistair at popple.id.au> writes:
> > Currently the only functions we have for initialising ipmi messages
> > with the correct values also allocate memory for the message. In some
> > cases we want to reuse previously allocated messages to avoid
> > continually freeing/allocating memory.
> > 
> > This patch introduces a function which (re)initialises a previously
> > allocated message and converts existing instances of this behaviour
> > over to the new function.
> fails make check:
> /tmp/cctmIzV0.o: In function `fru_write_complete':
> /home/stewart/skiboot/hw/ipmi/test/../ipmi-fru.c:184: undefined reference to
> `ipmi_init_msg'

So apparently I just write the tests, not run them :)

Thanks for catching. I will resubmit with fixes for the test.



More information about the Skiboot mailing list