[Skiboot] [PATCH] libflash: fix 4bytes address enablement on BMC SPI flash

Stewart Smith stewart at linux.vnet.ibm.com
Mon Dec 14 18:21:51 AEDT 2015

Cédric Le Goater <clg at fr.ibm.com> writes:
> commit e25f3f3559d9 ("libflash: enable 4b mode on BMC SPI flash") added
> a setting for 4byte addresses on the BMC SPI flash when needed. This
> setting should be only done for the BMC flash, which is not the case in
> the current code. This patch fixes it.
> Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>
> ---
>  I suppose we could have a ast_sf_set_4b() routine for each type of
>  flash. Would it make the code clearer ? 
>  hw/ast-bmc/ast-sf-ctrl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks! merged to master as of 6677d2c

More information about the Skiboot mailing list