[Skiboot] [PATCH] external/opal-prd: Set initial size value

Joel Stanley joel at jms.id.au
Fri Dec 11 10:59:56 AEDT 2015


On Fri, Dec 11, 2015 at 3:34 AM, Jeremy Kerr <jk at ozlabs.org> wrote:
> We're not initialising 'size' in handle_prd_control_run_cmd.

I had this ready to go too.

> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>

Reviewed-by: Joel Stanley <joel at jms.id.au>

> ---
>  external/opal-prd/opal-prd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
> index 115443c..a82000a 100644
> --- a/external/opal-prd/opal-prd.c
> +++ b/external/opal-prd/opal-prd.c
> @@ -1317,6 +1317,7 @@ static void handle_prd_control_run_cmd(struct control_msg *send_msg,
>         }
>
>         s = (char *)recv_msg->data;
> +       size = 0;
>         for (i = 0; i < argc; i++) {
>                 argv[i] = (char *)htobe64((uint64_t)&s[size]);
>                 size += (strlen(&s[size]) + 1);
> --
> 2.5.0
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot


More information about the Skiboot mailing list