[Skiboot] [PATCH v2] external/pflash: Fix makefile dependencies

Stewart Smith stewart at linux.vnet.ibm.com
Fri Dec 4 14:41:35 AEDT 2015

Joel Stanley <joel at jms.id.au> writes:
> When building under buildroot, libflash was being built before the
> links:
>  make[2]: *** No rule to make target 'libflash/libflash.c', needed by
>  'libflash-libflash.o'.  Stop.
>  make[2]: *** Waiting for unfinished jobs....
>      LN  ccan
>      LN  common
>      LN  libflash
> To reproduce this outside of buildroot, set PFLASH_VERSION to anything.
> This is another race that is only exposed in certain conditions. By
> describing the dependencies on the source files the build works again.
> I think it's almost time to stop using symlinks.
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
> V2:
>  - followed up on Stewarts suggestion to move the arch rules into the
>    commom/rules.mk where they should be
>  external/common/rules.mk | 20 ++++++++++++--------
>  external/pflash/rules.mk |  7 +++++--

Looks good - merged to master as of

Unfortunately, doesn't directly apply to stable as our makefiles are a
bit older there. Want something like this there?

More information about the Skiboot mailing list