[Skiboot] [PATCH] ipmi-sel: fix oem_sel attributes order

Cédric Le Goater clg at fr.ibm.com
Wed Dec 2 02:19:51 AEDT 2015

The patch corrects the order of the timestamp and manuf_id
attributes, which currently are reversed from what is stated
in the specs. (32. SEL Record Formats)

We don't use them in skiboot so there should not be any
consequences. This is mostly for the records and for qemu

Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>

 The AMI document is wrong on that topic.

 hw/ipmi/ipmi-sel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: skiboot.git/hw/ipmi/ipmi-sel.c
--- skiboot.git.orig/hw/ipmi/ipmi-sel.c
+++ skiboot.git/hw/ipmi/ipmi-sel.c
@@ -117,8 +117,8 @@ struct oem_sel {
 	/* SEL header */
 	uint8_t id[2];
 	uint8_t type;
-	uint8_t manuf_id[3];
 	uint8_t timestamp[4];
+	uint8_t manuf_id[3];
 	/* OEM SEL data (6 bytes) follows */
 	uint8_t netfun;
 	uint8_t cmd;

More information about the Skiboot mailing list