[Skiboot] [PATCH v2 4/5] external/opal-prd: Support manufacturing command HTMGT and attribute override

Jeremy Kerr jk at ozlabs.org
Tue Aug 25 14:45:08 AEST 2015

Hi Patrick,

>> Since we don't have interface version changes here, you'll need to
>> consume part of this reserved[] array if you add functions to the
>> runtime_interfaces struct.
> That's not true.  We purposefully have a big enough reserve that we are
> fine with NULL pointers between any two reasonable levels of Hostboot
> and Skiboot.  We're not going to add 32 functions between two levels we
> need common support between.

I don't understand why you wouldn't want to put these new pointers into
the previously-reserved area. Not doing so changes the size of the
struct shared between HBRT and opal-prd, which doesn't seem like a great
idea to me. Even if we do have fewer than 32 additions, we'd still be
accessing areas outside of the struct when running with an older HBRT.

Although this will *probably* behave okay for the foreseeable future,
we're dealing with distros that have 10+ years until EoL.



More information about the Skiboot mailing list