[Skiboot] [PATCH v2 3/5] external/opal-prd: Refactor the handle_prd_control() function

Jeremy Kerr jk at ozlabs.org
Tue Aug 25 10:52:52 AEST 2015


Hi Neelesh,

> Depending upon the control message type, the daemon parses the incoming
> messages, invoke the corresponding HBRT interface and sends the response
> back to the waiting client. Putting all this into one leads to cumbersome
> switch-case and a fat function.

Yep, this worked with a small number of control functions (with very
simple semantics), but it looks like we've outgrown that now.

Acked-by: Jeremy Kerr <jk at ozlabs.org>

Cheers,


Jeremy


More information about the Skiboot mailing list