[Skiboot] [PATCH 1/7 v3] external/opal-prd: Allow instance numbers for PRD ranges

Stewart Smith stewart at linux.vnet.ibm.com
Mon Aug 17 17:23:05 AEST 2015


Jeremy Kerr <jk at ozlabs.org> writes:
> diff --git a/external/opal-prd/hostboot-interface.h b/external/opal-prd/hostboot-interface.h
> index a518f50..3c162aa 100644
> --- a/external/opal-prd/hostboot-interface.h
> +++ b/external/opal-prd/hostboot-interface.h
> @@ -117,10 +117,11 @@ struct host_interfaces {
>  	 *  name.
>  	 *
>  	 *  @param[in] Devtree name (ex. "ibm,hbrt-vpd-image")
> +	 *  @param[in] Devtree instance
>  	 *  @return physical address of region (or NULL).
>  	 *  @platform FSP,OpenPOWER
>  	 */
> -	uint64_t (*get_reserved_mem)(const char*);
> +	uint64_t (*get_reserved_mem)(const char *name, uint32_t instance);
>  
>  	/**
>  	 * @brief  Force a core to be awake, or clear the force

Not exactly sure how adding a parameter like this without bumping the
hostboot interface version ends up being compatible... but hey, at least
it's the same as the HB side.

I guess the random content of r4 here will kind of end up working... but
this all makes it about as not-obviously correct as possible.



More information about the Skiboot mailing list