[Skiboot] [PATCH v1 5/5] external/opal-prd: opal-prd to support htmgt passthru and attribute override

[Patrick Williams]

On Wed, Aug 12, 2015 at 09:36:32PM +0530, Neelesh Gupta wrote:
> +static void handle_prd_control_htmgt_passthru(struct control_msg
> *send_msg,
> +                       struct control_msg *recv_msg)
...
> + pr_debug("CTRL: calling htmgt_pass_thru");
> + send_msg->response =3D call_htmgt_pass_thru(recv_msg->data_len,
> +                       recv_msg->data, &rsp_len,
> +                       send_msg->data);
> + send_msg->data_len =3D be16toh(rsp_len);

Is recv_msg->data_len in the correct endianness prior to calling
call_htmgt_pass_thru?  I don't see any obvious hto16be here, nor
in handle_prd_control.

> +static void handle_prd_control_attr_override(struct control_msg
> *send_msg,
> +                      struct control_msg *recv_msg)
...
> + pr_debug("CTRL: calling apply_attr_override");
> + send_msg->response =3D call_apply_attr_override(
> +         recv_msg->data, recv_msg->data_len);
> + send_msg->data_len =3D 0;
> +}

Same endianness question here.

> +
> +/* TODO usage */
>  static void usage(const char *progname)
>  {

Still TODO?  Looks like you did something.

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20150813/d59b1ee6/attachment.sig>