[Skiboot] [PATCH v2] IPMI: Fix eSEL size

[Alistair Popple]

Assuming we want to truncate PELs to 2K this looks ok. I couldn't find where in the BMC 
documentation it says BMC eSELs are limited to 2K, but I remember seeing it somewhere.

Acked-by: Alistair Popple <alistair at popple.id.au>

On Thu, 6 Aug 2015 15:10:58 Vasant Hegde wrote:
> Currently we are assuming Max PEL size is 64K. But in reality log size
> much lesser than this. Hence chose max size to 2K.
> 
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Cc: Alistair Popple <alistair at popple.id.au>
> Cc: Jeremy Kerr <jk at ozlabs.org>
> ---
>  hw/ipmi/ipmi-sel.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
> index 05ac977..e672ecf 100644
> --- a/hw/ipmi/ipmi-sel.c
> +++ b/hw/ipmi/ipmi-sel.c
> @@ -58,9 +58,10 @@ struct oem_sel {
>  
>  /* As far as I can tell the size of PEL record is unbounded (due to
>   * the possible presence of the user defined section). We chose this
> - * size because it's what FSP uses, but we could probably reduce
> - * it. */
> -#define MAX_PEL_SIZE 0x10000
> + * size because it's what hostboot also uses and most of the OPAL logs
> + * are few hundred bytes.
> + */
> +#define MAX_PEL_SIZE 0x800
>  
>  #define ESEL_HDR_SIZE 7
>  
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20150813/6f635773/attachment-0001.html>