[Skiboot] [PATCH v2] IPMI: Only log events that needs attention

[Ananth N Mavinakayanahalli]

On Mon, Aug 10, 2015 at 11:16:43AM +0530, Vasant Hegde wrote:
> Presently we are logging all the events to service processor (FSP/BMC).
> But on BMC machines we should only log events that requires attention.
> 
> As per PEL spec, we should log events with severity >= 0x22 and "service
> action flag" is "on". But in our case, all logs OPAL originagted logs
> are makred as report externally.
> 
> So lets log all events that are originated from OAPL (presently all logs
> as payload is not logging any PEL event) and  severity >= 0x22.
> 
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Cc: Ananth N Mavinakayanahalli <ananth at in.ibm.com>
> Cc: Alistair Popple <alistair at popple.id.au>
> Cc: Jeremy Kerr <jk at ozlabs.org>
> ---
>  hw/ipmi/ipmi-sel.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
> index f03f19e..fde1fee 100644
> --- a/hw/ipmi/ipmi-sel.c
> +++ b/hw/ipmi/ipmi-sel.c
> @@ -268,6 +268,13 @@ int ipmi_elog_commit(struct errorlog *elog_buf)
>  {
>  	struct ipmi_msg *msg;
> 
> +	/* Only log events that needs attention */
> +	if (elog_buf->event_severity < OPAL_PREDICTIVE_ERR_FAULT_RECTIFY_REBOOT ||
> +	    elog_buf->elog_origin != ORG_SAPPHIRE) {
> +		prlog(PR_INFO, "SEL: dropping non severe PEL event\n");

Should the tag be IPMI instead of SEL?

You may want to be a bit more verbose in the error specifying at least
the SRC or some such from the PEL that will tell us what event got dropped.

Ananth